perftest
perftest copied to clipboard
linux-rdma
Please avoid dashes in version
Debian uses dashes to separate the upstream version from the Debian revision. Please avoid dashes in version. Is there a reason why you use the dash? Why do you use 4.1-0.2 as version instead of just 4.1 or 4.1.2 or 4.1.0.2?
it is the version we are keeping in OFA years ago, can you further explain the upstream version and debian version ?
The Debian package version is constructed as following: {upstream_version}-{debian_revision}
The upstream version is the version that you - as upstream - pick. There are different approaches like semantic versioning or using the date (e.g. 2017.12). You picked 4.1-0.2. The debian_revision start with 1 on every new upstream version and is incremented in case we have to update the package. You can find a more detailed description in the Debian policy: https://www.debian.org/doc/debian-policy/#s-f-version
rpm-based distribution have the same concept. The Version field in the spec file contains the upstream version. The Release field in the spec file corresponds to the Debian revision and should probably start with 1 instead of 0.0. You also seem to include the Release part in your release version which is wrong.
To give an example: The release would just be called 4.2. The first Debian and rpm packages will be called 4.2-1. When just the packaging changes, that will be increased to 4.2-2. When you have to change the code, you will pick a new release number like 4.3 or 4.2.1. (which leads to packages with 4.3-1 or 4.2.1-1).
RedHat, Oracle, etc. use a similar approach. Also, the current spec has 4.2-0.0 but the release does not have a .tar.gz that matches. And a separate but related issue is that the URLs point to openfabrics and not GitHub. I was going to send a PR to fix this but would need a https://github.com/linux-rdma/perftest/releases/download/V4.2/perftest-4.2.tar.gz or similar to point to for the Source tag.
As the current packager of perftest in Fedora, I would also prefer semantic versioning. In the current Fedora perftest package, the dash is replaced by a dot in the Version field. I.e. it is "4.5.0.20". https://src.fedoraproject.org/rpms/perftest/blob/0c122819fe18f3839641d146a1b1bf09b906eebb/f/perftest.spec#_3
