perftest icon indicating copy to clipboard operation
perftest copied to clipboard

Fix insufficient polling in bidirectional test

Open amitgeron opened this issue 3 years ago • 4 comments

When run with multiple QPs, the CQ isn't guaranteed to be emptied due to insufficient number of entries passed to ibv_poll_cq(). This could lead to ibv_get_cq_event() to never return.

Fixes #137

amitgeron avatar Feb 03 '22 09:02 amitgeron

Thank you for your pull request. Could you please tell me the scenario that will reproduce this issue ( preferred with command) and what is the OS and rdma device that you are using?

HassanKhadour avatar Feb 06 '22 07:02 HassanKhadour

Sure :)

Command: ib_send_bw -b -e -q 16

OS: Ubuntu 18.04.5 LTS Kernel 5.9.7 (839e9e06c834ab488744eaa91f092c8b1ea0a139)

RNIC: Mellanox ConnectX-5

rdma-core: v33.1 (2504c0bab0a807455bfd0e7f516c86a07656e934)

perftest: v5.96 (ea61f3fe32a4c1d59907c4686edbd98a9757212f)

amitgeron avatar Feb 06 '22 07:02 amitgeron

When we can expect to merge this branch into main ? its literally blocker for our tests

mateuszmoga avatar Jul 18 '22 08:07 mateuszmoga

Hi @mateuszmoga @amitgeron , Thanks for your contribution! Please resolve the conflicts and the changes will be merged. Would appreciate if you describe the issue more in the commit message

HassanKhadour avatar Aug 03 '22 14:08 HassanKhadour

This didn't fix the issue for us and in addition there is a similar case in unidirectional BW test. Submitted another PR that is fixing both https://github.com/linux-rdma/perftest/pull/203.

mrgolin avatar Mar 16 '23 16:03 mrgolin

Hi @mateuszmoga @amitgeron , did the fix that @mrgolin provided solved the Issue? can we close this PR?

HassanKhadour avatar Mar 22 '23 08:03 HassanKhadour

Hi @mateuszmoga @amitgeron , did the fix that @mrgolin provided solved the Issue? can we close this PR?

Didn't test but looks fine

amitgeron avatar Mar 22 '23 09:03 amitgeron