Add RTR frames to TCP messages

[Vasili-Sk]

added < rtr %x %d.%d> message for received Remote transfer request messages in raw mode added < sendrtr %x > to send RTR message a little bit formatted files with eclipse CDT formatter

p.s. code needs optimisation... remove same used parts of code, make something like can_message_decode/encode to parse text. Too much same used code.

p.p.s. barely tested. However raspberry pi successfully sends rtr messages over tcp

[marckleinebudde]

Hey @Vasili-Sk, thanks for contributing.

• Please do the code reformating in a separate patch
• The patch description of your second patch is a bit vague, please describe which problem you're fixing.

Thanks, Marc

[Vasili-Sk]

Can i somehow edit changes here or need to make a new request?

[marckleinebudde]

You can force push your modified or rebased branch over the existing one, add the --force option to your git push command.

[Vasili-Sk]

Formatting removed in last commit, please check

[marckleinebudde]

The idea of re-formating the code is a good one, but please do either no reformating at all, or do the reformating in one patch and no other changes. Usually the first one.

[Vasili-Sk]

i have no idea how to, other than wiping my fork and making it from scratch :P

[marckleinebudde]

Check if this branch still works: https://github.com/marckleinebudde/socketcand/tree/vasili-sk/socketcand

[Vasili-Sk]

Looks ok so far

[marckleinebudde]

Can you take care of not setting the DLC to 0 in RTR frames?

[Vasili-Sk]

Do you want to set it manually?

[marckleinebudde]

No, please extend the protocol to transfer the DLC of RTR messages. Update the protocol description (https://github.com/linux-can/socketcand/blob/master/doc/protocol.md) too.

[Vasili-Sk]

Okay guide updated. DLC code also added.

[marckleinebudde]

It would have been good to place your changes ontop of my cleaned up branch....