audit-testsuite icon indicating copy to clipboard operation
audit-testsuite copied to clipboard

RFE: add file_permission test

Open rprobaina opened this issue 2 years ago • 4 comments

Add a very basic file permission change event filtering tests using the perl Test::Simple framework and with the file_delete test as inspiration.

See: https://github.com/linux-audit/audit-testsuite/issues/12

Signed-off-by: Ricardo Robaina [email protected]

rprobaina avatar Aug 16 '23 12:08 rprobaina

Hi @pcmoore,

First of all, thanks for being willing to review this PR.

I noticed that the CI syntax check failed and I just submitted a new version with the syntax format fixed.

This is my first contribution to audit-testsuite project. So, please let me know if there's anything I could do better next time.

Best regards, Ricardo

rprobaina avatar Aug 22 '23 13:08 rprobaina

Hi @rprobaina, thank you very much for the PR! I've got a couple of quick review comments but first I just wanted to say how much the additional test is appreciated :)

pcmoore avatar Aug 22 '23 20:08 pcmoore

Hi @rprobaina, thank you very much for the PR! I've got a couple of quick review comments but first I just wanted to say how much the additional test is appreciated :)

Hi @pcmoore, thanks for reviewing it! I've just pushed a new version containing the changes requested.

rprobaina avatar Aug 24 '23 16:08 rprobaina

Hi @pcmoore,

I pushed the reviewed version of this PR a few months ago, did have a chance to check it? Please, let me know if there's anything else I should do.

--Ricardo

rprobaina avatar Nov 29 '23 14:11 rprobaina

Merged via 9d2ddc2ea4411972b362cd011e658c575060238c, thanks @rprobaina!

pcmoore avatar Aug 28 '24 19:08 pcmoore