RFE: add file_permission test
Add a very basic file permission change event filtering tests using the perl Test::Simple framework and with the file_delete test as inspiration.
See: https://github.com/linux-audit/audit-testsuite/issues/12
Signed-off-by: Ricardo Robaina [email protected]
Hi @pcmoore,
First of all, thanks for being willing to review this PR.
I noticed that the CI syntax check failed and I just submitted a new version with the syntax format fixed.
This is my first contribution to audit-testsuite project. So, please let me know if there's anything I could do better next time.
Best regards, Ricardo
Hi @rprobaina, thank you very much for the PR! I've got a couple of quick review comments but first I just wanted to say how much the additional test is appreciated :)
Hi @rprobaina, thank you very much for the PR! I've got a couple of quick review comments but first I just wanted to say how much the additional test is appreciated :)
Hi @pcmoore, thanks for reviewing it! I've just pushed a new version containing the changes requested.
Hi @pcmoore,
I pushed the reviewed version of this PR a few months ago, did have a chance to check it? Please, let me know if there's anything else I should do.
--Ricardo
Merged via 9d2ddc2ea4411972b362cd011e658c575060238c, thanks @rprobaina!