apfsprogs icon indicating copy to clipboard operation
apfsprogs copied to clipboard

Add long option to apfs-label & apfs-snap

Open Integral-Tech opened this issue 1 year ago • 3 comments

Integral-Tech avatar Oct 05 '24 13:10 Integral-Tech

Hi, I already saw your pull requests a while ago, it's just that I'm doing a lot of work on apfsprogs locally and I don't want to make a mess. I'll probably look into it in a few days.

eafer avatar Oct 23 '24 15:10 eafer

Hi, I already saw your pull requests a while ago, it's just that I'm doing a lot of work on apfsprogs locally and I don't want to make a mess. I'll probably look into it in a few days.

Okay, thanks :)

Integral-Tech avatar Oct 23 '24 15:10 Integral-Tech

@eafer

Integral-Tech avatar Nov 03 '24 15:11 Integral-Tech

Do you need this to support long options for a particular reason?

eafer avatar Nov 04 '24 18:11 eafer

Do you need this to support long options for a particular reason?

Just because most of Linux commands, including file system user utilities, support --version argument.

Integral-Tech avatar Nov 04 '24 19:11 Integral-Tech

I just checked and the mkfs tools for ext4 and xfs don't have a long --version. In fact they don't use -v, they use -V heh. I think it's better to leave it as it is, I don't know if there are portability issues with getopt_long.

eafer avatar Nov 04 '24 20:11 eafer

I just checked and the mkfs tools for ext4 and xfs don't have a long --version. In fact they don't use -v, they use -V heh. I think it's better to leave it as it is, I don't know if there are portability issues with getopt_long.

Btrfs tool has --version option:

╰─❯ btrfs --version
btrfs-progs v6.11
-EXPERIMENTAL -INJECT -STATIC +LZO +ZSTD +UDEV +FSVERITY +ZONED CRYPTO=libgcrypt

Integral-Tech avatar Nov 05 '24 03:11 Integral-Tech

Sure, I know that plenty of other tools have --version. I just meant that it's not universal, so it's not a problem if it's missing.

eafer avatar Nov 05 '24 19:11 eafer