react-console-emulator
react-console-emulator copied to clipboard
linuswillner
Make a maxOutput prop?
I love what you've done with the project, it is by far the most usable and extendable react-based terminal. I noticed while using react-console-emulator, that the terminal can get very laggy when many high-speed terminal.pushToStdout() occur, and it gets much worse when the terminal output begins to be the length of millions. Implementing a solution using refs would be painful, and I think it would be much more reasonable to add the option for other people to use. I published a fork that implements the max output prop and submitted a pull request #1015.
Would this be something you are willing to implement?
Is there any plan to ever implement this? The pull request only has a single additional line of code, so it isn't much to review if you are worried about reviewing it. I also tested it utilizing the examples which are in the docs.