react-console-emulator icon indicating copy to clipboard operation
react-console-emulator copied to clipboard

Made maxOutput Prop

Open BjornTheProgrammer opened this issue 1 year ago • 3 comments

I noticed while using react-console-emulator, that the terminal can get very laggy when many high-speed terminal.pushToStdout() occur, and it gets much worse when the terminal output begins to be the length of millions. Implementing a solution using refs would be painful, and I think it would be much more reasonable to add the option for other people to use, as it is only one line of code.

BjornTheProgrammer avatar Aug 25 '22 23:08 BjornTheProgrammer

Sorry for spamming commits, I just kept remembering that I could make things a bit better.

BjornTheProgrammer avatar Oct 03 '22 17:10 BjornTheProgrammer

No problem, sorry for the delay - I don't really check in on this repo that often. I had one more suggestion but otherwise I think this is good.

linuswillner avatar Nov 18 '22 09:11 linuswillner

No problem, sorry for the delay - I don't really check in on this repo that often. I had one more suggestion but otherwise I think this is good.

Don't worry about the delay, I know you're busy and that you provided this project in your free time! Thank you for all the work you've put into refining this feature. Appreciate the help!

BjornTheProgrammer avatar Nov 20 '22 11:11 BjornTheProgrammer