Toggle CLI turns brightness up to 100%

[filmgarage]

If the screen is on and the command power off is sent, the screen is back to the former brightness when turned on again.

For example:

// Brightness 20%
rpi-backlight --p off //screen blank
rpi-backlight --p on // screen 20%

Toggle does not remember the former brightness:

// Brightness 20%
rpi-backlight --p toggle //screen blank
rpi-backlight --p toggle // screen 100%

Is this intentional? I would prefer the previous setting to be remembered.

[linusg]

Yep, that was recently discussed here: https://github.com/linusg/rpi-backlight/pull/40

I consider it a mistake and agree with

I would prefer the previous setting to be remembered.

But apparently it slipped through in the past. A fix would be very welcome!

[p1r473]

Hi Linus, My pull request includes a fix for this issue https://github.com/p1r473/rpi-backlight/blob/main/rpi_backlight/cli.py#L128

[linusg]

@p1r473 feel free to reopen it then! I generally don't do that myself.