orchid-tables icon indicating copy to clipboard operation
orchid-tables copied to clipboard

Published 20 hours ago • verified publisher icon lintaba

Orchid 13 support

Open cryptodev4 opened this issue 2 years ago • 10 comments

Expected Behavior

Hi I want to install Orchid-Tables on Orchid 13

Actual Behavior

I was trying to add Orchid-Tables by Lintaba on Orchid latest version (13) but I have a dependency error, does Orchid-Tables will support Orchid 13 version?

Steps to Reproduce the Problem

  1. Create a project with Laravel 9
  2. Install Orchid 13
  3. Try to install Orchid-Tables 1.1.1

Screenshots (if applicable)

image

Specifications

  • ORCHID Platform Version: 13
  • Laravel Version: 9
  • PHP Version: 8.1
  • Database Version: MariaDB 10.2

Other Notes

cryptodev4 avatar Aug 16 '22 15:08 cryptodev4

Same problem

Alessandro-Avallone-Developer avatar Aug 16 '22 15:08 Alessandro-Avallone-Developer

there were some breaking changes with orchid 13, and I haven't found the time yet to resolve those. Its mainly about how resources and assets are handled. Feel free to help out and send a PR :)

lintaba avatar Aug 18 '22 06:08 lintaba

Hi @lintaba, I was working in a workaround to make Orchid Tables work on Orchid 13, but I need permissions from you to create the branch with the changes and the PR to master to be reviewed.

cryptodev4 avatar Aug 18 '22 22:08 cryptodev4

I've created this fork just for test purposes and it works very well with Orchid 13 cryptodev4-orchid-tables maybe I don't deep dive into more details about functionality but the package finally can be installed.

cryptodev4 avatar Aug 18 '22 22:08 cryptodev4

Just to add more support I've been testing by adding a checkbox in the users list and this is the result.

Here I show the modal example with the checkbox selected

Then I send the modal and you can see that the 'checkbox' param arrives to the request

Then I show you how I configured the TDChecklist field

And finally show the composer.json

cryptodev4 avatar Aug 19 '22 00:08 cryptodev4

you shouldn't need permission to fork, or to create a PR.

Currently I havent had the time to review if there were any breaking change related to the two packages (however as I see the removal of jQuery may cause some troubles, for example.)

lintaba avatar Aug 19 '22 00:08 lintaba

Nice, I've already made the PR for the project, the only thing that I forget is to add the version release for the package, I think that you (@lintaba) fix that right? hehe

cryptodev4 avatar Aug 19 '22 14:08 cryptodev4

I realized that o made the commit with another account, I will change that

cryptodev4 avatar Aug 19 '22 18:08 cryptodev4

Another thing that I forget to said you (@lintaba ), is that jQuery can be added again via platform file, so I specify that detail on the readme file of lintaba/orchid-tables, and I think that jQuery version that suggest Orchid Platform could be fine to work without issues.

cryptodev4 avatar Aug 19 '22 19:08 cryptodev4

@cryptodev4 jQuery was just a quick example, from a list of breaking changes. If/when i'll have time to update the lib i'll do so. If you can show that your changes are actually working (by working I mean all of the functionality of the lib are the same with the new version as it was with the old, it can be installed to a fresh instance, and also can be used to update from the old version), then I can apply the PR.

Meanwhile, feel free fork it and use that.

lintaba avatar Aug 19 '22 19:08 lintaba