python-memcached icon indicating copy to clipboard operation
python-memcached copied to clipboard

SyntaxWarnings with Python 3.8

Open tlc28 opened this issue 4 years ago • 6 comments

Hi,

I've recently updated to Python 3.8 and python-memcached now emits 2 syntax warnings:

memcache.py:1303: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key is '':
memcache.py:1304: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if key_extra_len is 0:

Would be great if you could fix this… and publish a patch-version on pypi!

Best regards

tlc28 avatar Jun 12 '20 13:06 tlc28

Same here!

pablondrina avatar Aug 14 '20 11:08 pablondrina

Also Getting this issue.

JaredOzzy avatar Aug 19 '20 10:08 JaredOzzy

I have created https://github.com/linsomniac/python-memcached/pull/178 to fix this

tirkarthi avatar Oct 21 '20 14:10 tirkarthi

Thanks @tirkarthi !

tlc28 avatar Oct 21 '20 15:10 tlc28

Is there anybody who can merge it?

random1st avatar Mar 17 '21 09:03 random1st

The same problem.

victorelec14 avatar Nov 16 '21 15:11 victorelec14

Was this fixed? Can it be closed? https://github.com/linsomniac/python-memcached/blob/5c5cb1bc965c941f93b166d7ab2c055e3d8261e0/memcache.py#L1309-L1310

cclauss avatar Jan 30 '24 17:01 cclauss

I agree with @cclauss that this has been resolved, closing.

linsomniac avatar Jan 30 '24 22:01 linsomniac