linovia
Removed v1 HipChat API support, implemented v2 support.
As we discussed in my previous PR, I removed the support for v1 completely. Have tested the plugin on our local sentry installs (6.x.x up to 7.7.0) and the functionality is the same as when there was still support for both API's when testing on the v2 API.
Note: Sorry about the duplicate request
@MitchellXen I need to look at a few things -- mostly I need to figure out if we can cleanly transition v1 => v2 without forcing people to migrate. Didn't really consider this before.
(I don't know the answer simply because I haven't looked at the API)
@dcramer True but people are not forced to update the plugin yet right? As I believe the v2 API has been around for about a year now and the hosted HipChat server will drop v1 support pretty soon this plugin will need v2 support pretty soon.
An other option would be the code I did a PR for earlier with both v1 and v2 support.
@MitchellXen mostly I'm thinking about "how do we migrate getsentry.com to the new version of the plugin"
If we dont have a good solution maybe we'll just pull in the v1 + v2 support instead.
v1 is already deprecated by Hipchat, please accept the PR in order to support v2 from now on. As claimed by the submitter, the v1 version of your plugin can still be used by whoever wishes to use it.
We're going to have to punt on upgrading to this as we have to have a migration path for getsentry.com.
That said we're working closely with HipChat on their new integration platform which is going to be launched (in beta) at the Atlassian event in November. We already have a functional integration and a migration path, and it seems like its more worthwhile to focus the effort on improving that than switching to an intermediate version.
We haven't yet open sourced that integration, but we will once we clean up a few things.