manager
manager copied to clipboard
M3-5867: Marketplace refinement search and filtering
Description
What does this PR do?
How to test
What are the steps to reproduce the issue or verify the changes?
How do I run relevant unit tests?
Adding these comments here because this ticket is still open. @codyfinn let me know if these changes are possible.
- Change width of category dropdown so Media & Entertainment is not truncated when selected
- Change search bar hint text to
Search for app name - Decrease height of Apps window to 450px to optimize for lower resolution viewports
I seem to be getting info weird states when choosing a category and searching at the same time.
- When I clear the search bar, I wouldn't expect the category to automatically clear
- When I clear both the search bar and the category, the sections such as
New appsare gone and I would expect them to be there
https://user-images.githubusercontent.com/6440455/184375526-dc8c7920-d12a-4465-8800-ca0735caef63.mov
I seem to be getting info weird states when choosing a category and searching at the same time.
* When I clear the search bar, I wouldn't expect the category to automatically clear * When I clear both the search bar and the category, the sections such as `New apps` are gone and I would expect them to be thereScreen.Recording.2022-08-12.at.10.28.51.AM.mov
The behavior shown is intended. Currently you can only search by name of filter by category. Not both at the same time
I'm noticing an issue that's preventing me from resetting my search. To reproduce:
- Select any category
- Without clearing the category, type in a search query and press the enter key
- Observe that your search results appear and the category field is cleared as expected
- Clear the search field and press the enter key
- Observe that your search is not reset as expected
If you don't select a category first, or if you clear our your category selection before typing a search query, this issue doesn't occur.
As far as the UX goes, I was kind of thrown off by the fact that the only way to reset your search is to manually clear the fields (and in the case of the search field, submit the cleared value). I'm wondering if having some kind of reset link or button would be more intuitive?
I'm noticing an issue that's preventing me from resetting my search. To reproduce:
1. Select any category 2. Without clearing the category, type in a search query and press the enter key 3. Observe that your search results appear and the category field is cleared as expected 4. Clear the search field and press the enter key 5. Observe that your search is not reset as expectedIf you don't select a category first, or if you clear our your category selection before typing a search query, this issue doesn't occur.
As far as the UX goes, I was kind of thrown off by the fact that the only way to reset your search is to manually clear the fields (and in the case of the search field, submit the cleared value). I'm wondering if having some kind of reset link or button would be more intuitive?
My latest commit should fix this. Though I am curious if it also fixes the issue you are having where you need to press Enter in order to get the query to filter the apps. Let me know if this fixes that as well.
My latest commit should fix this. Though I am curious if it also fixes the issue you are having where you need to press
Enterin order to get the query to filter the apps. Let me know if this fixes that as well.
Nice! Thanks Cody, confirming that both issues mentioned here are fixed! I'll keep looking at this today after stand up.