linode
upcoming: [DI-28500] - Enable the Alerts Notification Channel Tab
Description 📝
Enable the Notification Channel Tab
Changes 🔄
List any change(s) relevant to the reviewer.
- Filter the enabled tabs and render them
- Placeholder Notification Channel Listing component
Scope 🚢
Upon production release, changes in this PR will be visible to:
- [ ] All customers
- [x] Some customers (e.g. in Beta or Limited Availability)
- [ ] No customers / Not applicable
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot <img src="" /> or video <video src="" /> of the change.
:lock: Use the Mask Sensitive Data setting for security.
:bulb: For changes requiring multiple steps to validate, prefer a video for clarity.
| Before | After |
|---|---|
How to test 🧪
Prerequisites
(How to setup test environment)
- Currently in DevCloud the flag has been enabled
- In local, using the dev tool enable or disable the notificationChannels boolean flag under CloudPulse Alerting
Verification steps
(How to verify changes)
- [ ] The Notification Channels tab should be visible only when the flag is enabled
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review ❔ Our contribution guidelines 🤏 Splitting feature into small PRs ➕ Adding a changeset 🧪 Providing/improving test coverage 🔐 Removing all sensitive information from the code and PR description 🚩 Using a feature flag to protect the release 👣 Providing comprehensive reproduction steps 📑 Providing or updating our documentation 🕛 Scheduling a pair reviewing session 📱 Providing mobile support ♿ Providing accessibility support
- [x] I have read and considered all applicable items listed above.
As an Author, before moving this PR from Draft to Open, I confirmed ✅
- [x] All tests and CI checks are passing
- [x] TypeScript compilation succeeded without errors
- [x] Code passes all linting rules
[!IMPORTANT] Since the next release includes LA release for Cloudpulse products, we are going to hold the new changes and not merge them for this release. So going to hold this PR until we are ready.
Since the failing cypress tests are not due to the PR changes . Will be merging this PR.
Cloud Manager UI test results
:small_red_triangle: 6 failing tests on test run #14 ↗︎
| :x: Failing | :white_check_mark: Passing | :arrow_right_hook: Skipped | :clock1: Duration |
6 Failing | 825 Passing | 11 Skipped | 53m 42s |
Details
| Failing Tests | ||
|---|---|---|
| Spec | Test | |
| :x: | create-linode.spec.ts | Cloud Manager Cypress Tests→Create Linode→End-to-end→By plan type » creates a Premium CPU Linode |
| :x: | create-linode-blackwell.spec.ts | Cloud Manager Cypress Tests→smoketest for Nvidia blackwell GPUs in linodes/create page » disables Blackwells if disabled region selected |
| :x: | create-linode-blackwell.spec.ts | Cloud Manager Cypress Tests→smoketest for Nvidia blackwell GPUs in linodes/create page » enables Blackwells if enabled region selected |
| :x: | plan-selection.spec.ts | Cloud Manager Cypress Tests→displays specific linode plans for GPU » Should render divided tables when GPU divider enabled |
| :x: | plan-selection.spec.ts | Cloud Manager Cypress Tests→displays specific kubernetes plans for GPU » Should render divided tables when GPU divider enabled |
| :x: | lke-create.spec.ts | Cloud Manager Cypress Tests→smoketest for Nvidia Blackwell GPUs in kubernetes/create page→standard tier » enabled feature flag includes blackwells |
Troubleshooting
Use this command to re-run the failing tests:
pnpm cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts,cypress/e2e/core/linodes/create-linode-blackwell.spec.ts,cypress/e2e/core/linodes/plan-selection.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"
