manager
manager copied to clipboard
chore: [M3-10181] - Improve and refactor LISH Console Settings page
Description 📝
This PR makes improvements and refactors to the /profile/lish page
- Technical changes
- Updates code not use
ramda📦 - Refactors to use
react-hook-form - Corrects inaccurate
Profileapi-v4 type
- Updates code not use
- User facing changes 👨
- Better form error handling 🚫
- Two
Papers instead of one to make the UI more consumable 📄 - Added a Docs link 📃
- Moves helper text to make page more readable
- Allows pasting a comma separated list of SSH keys 🔑
- This is an Easter Egg / Proof of concept 🥚 If we like it we can formalize it. (M3-9885)
Preview 📷
Normal State
| Before | After |
|---|---|
Error State
| Before | After |
|---|---|
How to test 🧪
- Check out this PR locally or use the preview link
- Manually test functionality on the
/profile/lishpage
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review ❔ Our contribution guidelines 🤏 Splitting feature into small PRs ➕ Adding a changeset 🧪 Providing/improving test coverage 🔐 Removing all sensitive information from the code and PR description 🚩 Using a feature flag to protect the release 👣 Providing comprehensive reproduction steps 📑 Providing or updating our documentation 🕛 Scheduling a pair reviewing session 📱 Providing mobile support ♿ Providing accessibility support
- [ ] I have read and considered all applicable items listed above.
As an Author, before moving this PR from Draft to Open, I confirmed ✅
- [ ] All unit tests are passing
- [ ] TypeScript compilation succeeded without errors
- [ ] Code passes all linting rules
Cloud Manager UI test results
:small_red_triangle: 2 failing tests on test run #5 ↗︎
| :x: Failing | :white_check_mark: Passing | :arrow_right_hook: Skipped | :clock1: Duration |
2 Failing | 658 Passing | 6 Skipped | 113m 49s |
Details
| Failing Tests | ||
|---|---|---|
| Spec | Test | |
| :x: | object-storage.e2e.spec.ts | Cloud Manager Cypress Tests→object storage end-to-end tests » object storage end-to-end tests |
| :x: | access-key.e2e.spec.ts | Cloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests |
Troubleshooting
Use this command to re-run the failing tests:
pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"