linode
upcoming: [DI-25592] - Added EntityScopeSelect component for create alert page
Description 📝
Added an EntityScopeSelect dropdown for alert create & edit page.
Changes 🔄
List any change(s) relevant to the reviewer.
- EntityScopeSelect component is added
- Added scope property in alert related types
- Added a ServiceAlert interface in cloudpulse types.ts
- Renamed ServiceTypes interface to Service for better naming convention.
Target release date 🗓️
July 1st
Preview 📷
Include a screenshot or screen recording of the change.
:lock: Use the Mask Sensitive Data setting for security.
:bulb: Use <video src="" /> tag when including recordings in table.
| Before | After |
|---|---|
How to test 🧪
- Switch as mock user and got to alerts from mega menu
- Click on create alert button that will take you to create alert page
- At line 213 after severity select in CreateAlertDefinition.tsx, add the below code to show entity scope select
<AlertEntityScopeSelect name="scope" serviceType={serviceTypeWatcher} /> - You can select service type and based on that scope select dropdown will behave.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review ❔ Our contribution guidelines 🤏 Splitting feature into small PRs ➕ Adding a changeset 🧪 Providing/improving test coverage 🔐 Removing all sensitive information from the code and PR description 🚩 Using a feature flag to protect the release 👣 Providing comprehensive reproduction steps 📑 Providing or updating our documentation 🕛 Scheduling a pair reviewing session 📱 Providing mobile support ♿ Providing accessibility support
- [ ] I have read and considered all applicable items listed above.
As an Author, before moving this PR from Draft to Open, I confirmed ✅
- [ ] All unit tests are passing
- [ ] TypeScript compilation succeeded without errors
- [ ] Code passes all linting rules
@cpathipa @hasyed-akamai pls review & provide second approval on this PR. I've couple of more dependent PRs to raise
Cloud Manager UI test results
:small_red_triangle: 2 failing tests on test run #12 ↗︎
| :x: Failing | :white_check_mark: Passing | :arrow_right_hook: Skipped | :clock1: Duration |
2 Failing | 659 Passing | 5 Skipped | 126m 43s |
Details
| Failing Tests | ||
|---|---|---|
| Spec | Test | |
| :x: | resize-linode.spec.ts | Cloud Manager Cypress Tests→resize linode » resize linode |
| :x: | object-storage.e2e.spec.ts | Cloud Manager Cypress Tests→object storage end-to-end tests » object storage end-to-end tests |
Troubleshooting
Use this command to re-run the failing tests:
pnpm cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"
