manager
manager copied to clipboard
fix: Dark Mode style regressions
Description ๐
- I caused some minor dark mode regressions in https://github.com/linode/manager/pull/11081
- This fixes the regressions by merging the theme options before calling
createTheme
Related Docs ๐
See https://v5.mui.com/material-ui/customization/theming/#createtheme-options-args-theme
I think the key point is
Only the first argument (options) is processed by the createTheme function.
Calling createTheme before merging the raw options has implications that I didn't foresee. Calling createTheme with the theme options merged first fixes the issues we are seeing
Screenshots of the Issues ๐ท
How to test ๐งช
- Checkout this PR (or just use the preview link)
- Verify the regressions in the "Screenshots" section are all fixed ๐ง
As an Author I have considered ๐ค
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support