manager
manager copied to clipboard
refactor: [M3-8746] – Move `inputMaxWidth` into `Theme`
Description 📝
Follow-up to https://github.com/linode/manager/pull/11092 -- move inputMaxWidth into Theme so we can reference it as theme.inputMaxWidth as opposed to exporting & importing the inputMaxWidth variable
Changes 🔄
- Add
inputMaxWidthtoTheme - Replace uses of
inputMaxWidthvariable in components withtheme.inputMaxWidth
Target release date 🗓️
10/28/24
How to test 🧪
Verification steps
Confirm there are no width regressions for the VPC and Security sections in the Linode Create flow
As an Author I have considered 🤔
- [X] 👀 Doing a self review
- [X] ❔ Our contribution guidelines
- [X] 🤏 Splitting feature into small PRs
- [X] ➕ Adding a changeset
- [X] 🧪 Providing/Improving test coverage
- [X] 🔐 Removing all sensitive information from the code and PR description
- [X] 🚩 Using a feature flag to protect the release
- [X] 👣 Providing comprehensive reproduction steps
- [X] 📑 Providing or updating our documentation
- [X] 🕛 Scheduling a pair reviewing session
- [X] 📱 Providing mobile support
- [X] ♿ Providing accessibility support
Coverage Report: ✅
Base Coverage: 87.06%
Current Coverage: 87.06%
Would we need a changeset for the manager package?
I would say no, having one for the linode/ui package is sufficient since it's just removing an import on the manager side. I can add one if there's disagreement though
Cloud Manager E2E
Run #6707
Run Properties:
Passed #6707 •
26d7ea345f: refactor: [M3-8746] – Move `inputMaxWidth` into `Theme` (#11116)
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 00s |
| Commit |
|
| Committer | Dajahi Wiley |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
2
|
|
|
2
|
|
|
0
|
|
|
438
|
| View all changes introduced in this branch ↗︎ | |