manager
manager copied to clipboard
fix: [M3-8533] - Broken firewall rules table
Description 📝
The table/list header row in the firewall rules table is not the correct color in dark/light mode. It is hard to tell that it is intended to be a table/list header.
Changes 🔄
- Changed the Firewall rules table to match our normal tables.
- Updated the styles to match our normal table colors.
- Updated
PolicyRow- Changed it to have borders on all sides.
- Changed the alignment of the Select and helper text to be aligned with the Action column for screens <
lg, and with the last column for screens >=lg.
Target release date 🗓️
N/A
Preview 📷
| Breakpoints | Before | After |
|---|---|---|
lg |
||
between sm and lg |
||
sm |
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
- Go to any Firewall details page (https://cloud.linode.com/firewalls/948204/rules)
- Observe the broken looking table (in both dark and light mode)
Verification steps
- Ensure the table is not broken in both dark and light modes.
- Verify table across different screen sizes and ensure it matches our normal table colors.
As an Author I have considered 🤔
Check all that apply
- [ ] 👀 Doing a self review
- [x] ❔ Our contribution guidelines
- [x] 🤏 Splitting feature into small PRs
- [x] ➕ Adding a changeset
- [ ] 🧪 Providing/Improving test coverage
- [ ] 🔐 Removing all sensitive information from the code and PR description
- [ ] 🚩 Using a feature flag to protect the release
- [ ] 👣 Providing comprehensive reproduction steps
- [ ] 📑 Providing or updating our documentation
- [ ] 🕛 Scheduling a pair reviewing session
- [ ] 📱 Providing mobile support
- [ ] ♿ Providing accessibility support
Coverage Report: ✅
Base Coverage: 87.06%
Current Coverage: 87.06%
@abailly-akamai I’ll explore this further and see how we can approach it effectively. Thanks!