manager
manager copied to clipboard
feat: [LKEAPIFW-428] LKE clusters should have IP ACL integration on CM (part 1)
Description ๐
Enables creation of LKE clusters with IP ACLS; enables updates of already migrated clusters
Changes ๐
- Adds new UI components
- adds respective library calls
- some style cleanup
*** tests will be on a separate PR
Target release date ๐๏ธ
Oct 28th release
Preview ๐ท
Cluster creation:
Cluster summary:
| IPACL enabled | IPACL not enabled |
|---|---|
New IPACL Drawer:
| Cluster migrated (IPACL enabled/not enabled) | Cluster not yet migrated |
|---|---|
How to test ๐งช
Spin up this branch, update to reach alpha's apinext backend. Once all set, attempt to create new clusters with ipacls and then update them.
Prerequisites
See how to test
Verification steps
- Create a Cluster with IPACL enabled (toggled on). Confirm button on summary page lists number of IPs added
- Create a Cluster with IPACL disabled (toggled off). Confirm button on summary page says 'Enable'. If you added any IPs, confirm they show up in the drawer
- Create a Cluster that does not have IPACL. Confirm button on summary page says 'Enable' (it will take several seconds to load) and that drawer matches the screenshot for 'Cluster not yet migrated'. Update/toggle IPACL, confirm flow now follows a cluster with IPACL enabled
- See Talmai's comment for how to create these clusters. I'v also just been creating clusters on alpha (but not on this branch/using the develop branch), and then going back to this branch
- general spotcheck of Kubernetes with both the APL flag on and off
As an Author I have considered ๐ค
Check all that apply
- โ ๐ Doing a self review
- โ โ Our contribution guidelines
- โ ๐ค Splitting feature into small PRs
- [NO see comment] โ Adding a changeset
- [NO ] ๐งช Providing/Improving test coverage
- โ ๐ Removing all sensitive information from the code and PR description
- [NO] ๐ฉ Using a feature flag to protect the release
- โ ๐ฃ Providing comprehensive reproduction steps
- [NO] ๐ Providing or updating our documentation
- [NO] ๐ Scheduling a pair reviewing session
- [N/A] ๐ฑ Providing mobile support
- [N/A] โฟ Providing accessibility support