manager icon indicating copy to clipboard operation
manager copied to clipboard

feat: [LKEAPIFW-428] LKE clusters should have IP ACL integration on CM (part 1)

Open talmai opened this issue 1 year ago โ€ข 14 comments

Description ๐Ÿ“

Enables creation of LKE clusters with IP ACLS; enables updates of already migrated clusters

Changes ๐Ÿ”„

  • Adds new UI components
  • adds respective library calls
  • some style cleanup

*** tests will be on a separate PR

Target release date ๐Ÿ—“๏ธ

Oct 28th release

Preview ๐Ÿ“ท

Cluster creation:

Cluster summary:

IPACL enabled IPACL not enabled
Screenshot 2024-09-04 at 14 47 05 Screenshot 2024-10-08 at 18 28 48

New IPACL Drawer:

Cluster migrated (IPACL enabled/not enabled) Cluster not yet migrated
Screenshot 2024-09-04 at 14 47 05 Screenshot 2024-10-08 at 18 28 48

How to test ๐Ÿงช

Spin up this branch, update to reach alpha's apinext backend. Once all set, attempt to create new clusters with ipacls and then update them.

Prerequisites

See how to test

Verification steps

  • Create a Cluster with IPACL enabled (toggled on). Confirm button on summary page lists number of IPs added
  • Create a Cluster with IPACL disabled (toggled off). Confirm button on summary page says 'Enable'. If you added any IPs, confirm they show up in the drawer
  • Create a Cluster that does not have IPACL. Confirm button on summary page says 'Enable' (it will take several seconds to load) and that drawer matches the screenshot for 'Cluster not yet migrated'. Update/toggle IPACL, confirm flow now follows a cluster with IPACL enabled
    • See Talmai's comment for how to create these clusters. I'v also just been creating clusters on alpha (but not on this branch/using the develop branch), and then going back to this branch
    • general spotcheck of Kubernetes with both the APL flag on and off

As an Author I have considered ๐Ÿค”

Check all that apply

  • โœ… ๐Ÿ‘€ Doing a self review
  • โœ… โ” Our contribution guidelines
  • โœ… ๐Ÿค Splitting feature into small PRs
  • [NO see comment] โž• Adding a changeset
  • [NO ] ๐Ÿงช Providing/Improving test coverage
  • โœ… ๐Ÿ” Removing all sensitive information from the code and PR description
  • [NO] ๐Ÿšฉ Using a feature flag to protect the release
  • โœ… ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [NO] ๐Ÿ“‘ Providing or updating our documentation
  • [NO] ๐Ÿ•› Scheduling a pair reviewing session
  • [N/A] ๐Ÿ“ฑ Providing mobile support
  • [N/A] โ™ฟ Providing accessibility support

talmai avatar Sep 19 '24 06:09 talmai