refactor: [M3-8501] - AccessSelect Optimization: Use React Hook Form
Description ๐
The goal is to see if we can eliminate the number of useState calls we're making in this file and potentially remove the useEffect by using React Hook Form and inferring values from other values.
Changes ๐
- Replaced the existing queries with
react-queryqueries and mutations for managing state - Used React Hook Form for better state management
Target release date ๐๏ธ
N/A
How to test ๐งช
Verification steps
- Check if the AccessSelect component's functionality is unaffected by the changes
As an Author I have considered ๐ค
Check all that apply
- [x] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
@harsh-akamai can you make sure to fix your unit tests before people review the PR?
@abailly-akamai I have fixed the failing unit tests
Coverage Report: โ
Base Coverage: 87.05%
Current Coverage: 87.05%
@harsh-akamai what is the status of this PR? @jaalah-akamai I think you requested changes, unsure if they have been addressed.
May be a good idea to rebase for good measure as well ๐
Yea @harsh-akamai let's rebase and I'll give this another pass today ๐
Rebased the PR with the latest changes on develop
Cloud Manager E2Eย
ย
Run #6717
Run Properties:ย
ย Passedย #6717 ย โขย
43000641db: refactor: [M3-8501] - AccessSelect Optimization: Use React Hook Form (#10952)
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 41s |
| Commit |
|
| Committer | Harsh Shankar Rao |
| View all properties for this run โ๏ธ | |
| Test results | |
|---|---|
|
|
0
|
|
|
3
|
|
|
2
|
|
|
0
|
|
|
438
|
| View all changes introduced in this branch โ๏ธ | |