manager icon indicating copy to clipboard operation
manager copied to clipboard

refactor: [M3-8501] - AccessSelect Optimization: Use React Hook Form

Open harsh-akamai opened this issue 1 year ago โ€ข 3 comments

Description ๐Ÿ“

The goal is to see if we can eliminate the number of useState calls we're making in this file and potentially remove the useEffect by using React Hook Form and inferring values from other values.

Changes ๐Ÿ”„

  • Replaced the existing queries with react-query queries and mutations for managing state
  • Used React Hook Form for better state management

Target release date ๐Ÿ—“๏ธ

N/A

How to test ๐Ÿงช

Verification steps

  • Check if the AccessSelect component's functionality is unaffected by the changes

As an Author I have considered ๐Ÿค”

Check all that apply

  • [x] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [ ] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

harsh-akamai avatar Sep 17 '24 12:09 harsh-akamai

@harsh-akamai can you make sure to fix your unit tests before people review the PR?

abailly-akamai avatar Sep 18 '24 13:09 abailly-akamai

@abailly-akamai I have fixed the failing unit tests

harsh-akamai avatar Sep 20 '24 11:09 harsh-akamai

Coverage Report: โœ…
Base Coverage: 87.05%
Current Coverage: 87.05%

github-actions[bot] avatar Sep 20 '24 12:09 github-actions[bot]

@harsh-akamai what is the status of this PR? @jaalah-akamai I think you requested changes, unsure if they have been addressed.

May be a good idea to rebase for good measure as well ๐Ÿ‘

abailly-akamai avatar Oct 22 '24 13:10 abailly-akamai

Yea @harsh-akamai let's rebase and I'll give this another pass today ๐Ÿ‘

jaalah-akamai avatar Oct 22 '24 13:10 jaalah-akamai

Rebased the PR with the latest changes on develop

harsh-akamai avatar Oct 22 '24 14:10 harsh-akamai

Cloud Manager E2Eย  ย  Run #6717

Run Properties:ย  status check passedย Passedย #6717 ย โ€ขย  git commit 43000641db: refactor: [M3-8501] - AccessSelect Optimization: Use React Hook Form (#10952)
Project Cloud Manager E2E
Branch Review develop
Run status status check passedย Passedย #6717
Run duration 25m 41s
Commit git commit 43000641db: refactor: [M3-8501] - AccessSelect Optimization: Use React Hook Form (#10952)
Committer Harsh Shankar Rao
View all properties for this run โ†—๏ธŽ

Test results
Tests that failedย  Failures 0
Tests that were flakyย  Flaky 3
Tests that did not run due to a developer annotating a test with .skipย  Pending 2
Tests that did not run due to a failure in a mocha hookย  Skipped 0
Tests that passedย  Passing 438
View all changes introduced in this branch โ†—๏ธŽ

cypress[bot] avatar Oct 22 '24 22:10 cypress[bot]