manager icon indicating copy to clipboard operation
manager copied to clipboard

change: [M3-8379] - Disable Region in OS tab for unsupported distributed images

Open hana-akamai opened this issue 1 year ago โ€ข 0 comments

Description ๐Ÿ“

Not all Linux Distributions in the Linode Create OS tab support distributed regions. We want to disable a region if the selected OS does not have a distributed capability similar to the Images tab

Changes ๐Ÿ”„

  • Remove specific check for linodeCreateTab in getDisabledRegions so that any selected image that does not have the distributed-sites capability is disabled
  • Minor UI positioning fix for distributed helper text w/ region error text

Preview ๐Ÿ“ท

Gecko Before After
Beta v2-beta-before-os v2-beta-after-os
Beta image image
LA / GA v2-la-before-os v2-la-after-os

How to test ๐Ÿงช

Prerequisites

(How to setup test environment)

  • Ensure your account has the new-dc-testing-gecko, edge_testing and edge_compute customer tags
  • Pull this PR and run it locally pointing to dev API

Reproduction steps

(How to reproduce the issue, if applicable)

  • Checkout develop locally while pointing to the dev API
  • Go to the Linode Create flow
  • Notice that distributed regions are not disabled for unsupported distributed images (no distributed icon, e.g. Debian 11)

Verification steps

(How to verify changes)

  • Go to the Linode Create flow and verify the v1 and v2 flows for Gecko Beta & Gecko LA/GA
    • To test Gecko Beta locally, you can add the following to useFlags.ts:
    • We do not want to change the LD flag globally since other teams rely on it
    • ...mockFlags, gecko2: { enabled: true, ga: false }
  • Verify unsupported distributed regions (no distributed icon, e.g. Debian 11)
    • Gecko LA/GA: Regions in the Distributed tab should be disabled with tooltip
    • Gecko Beta: Distributed regions in the single dropdown should be disabled with tooltip
  • Verify supported distributed regions (distributed icon, e.g. Ubuntu 24.04 LTS)
    • Gecko LA/GA: Regions in the Distributed tab should not be disabled
    • Gecko Beta: Distributed regions in the single dropdown should not be disabled

As an Author I have considered ๐Ÿค”

Check all that apply

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [x] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [x] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

hana-akamai avatar Aug 28 '24 18:08 hana-akamai