manager
manager copied to clipboard
fix: [M3-8500] - Restricted users without account access unable to create Linodes on Linode Create v2
Description ๐
- Updates Linode Create v2 to be in parity with Linode Create v1 when it comes to a restricted user creating a Linode in an EU region
The Bug ๐
- On Linode Create v2, if a user with
add_linodesaccess, but with no account/billing permissions tried to create a LInode, they would see an infinite loading spinner. This is because Cloud Manager was trying to GET/v4/account/agreemeents, but failed to because the endpoint will 403 for this restricted user.
The Fix ๐ง
- Allow restricted users with
add_linodesaccess but with no account/billing permissions to create Linodes regardless of the account's agreements. - This seems questionable, but this is what Linode Create v1 intentionally did. See https://github.com/linode/manager/pull/7901
Target release date ๐๏ธ
9/3/24
Preview ๐ท
| Before | After |
|---|---|
| User would see an infinite loading spinner | User can create a Linode |
How to test ๐งช
Prerequisites
- Create a restricted user on your account with the following permissions
-
add_linodes: true(Can add Linodes to this accountin the UI) -
account_access: null(No billing access in the UI)
-
Reproduction steps
- Login as the restricted user
- Try to create a LInode in an EU region
- Observe an infinite loading spinner when you click "Create Linode" button
Verification steps
- Repeat the "Reproduction steps" with this PR checked out
- Rather than seeing an infinite loading spinner, you should be able to successfully create a Linode in an EU region
As an Author I have considered ๐ค
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 82.73%
Current Coverage: 82.73%