refactor: N/A - Infer type for `value` to `number` in `expiry_year` validation

Open h3ssan opened this issue 1 year ago • 0 comments

Description 📝

In the CreditCardSchema validation, the expiry_year field has a test to ensure the expiration year is 2 or 4 digits. The test function takes a value parameter, which is inferred to be a number type.

Changes 🔄

Modified file: packages/validation/src/account.schema.ts
Change the parameter from value with no type, into value: number.

Target release date 🗓️

It's just a refactor, not critical.

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

Reproduction steps

(How to reproduce the issue, if applicable)

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

[X] 👀 Doing a self review
[X] ❔ Our contribution guidelines
[X] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿ Providing accessibility support

Aug 27 '24 22:08 h3ssan