manager icon indicating copy to clipboard operation
manager copied to clipboard

refactor: [M3-8331] - useToastNotification async toasts

Open pmakode-akamai opened this issue 1 year ago โ€ข 3 comments

Description ๐Ÿ“

const toasts: Toasts = { ... } ย should be moved to the event directory and map to event messages already defined in our new factory

Changes ๐Ÿ”„

  • Refactor useToastNotification.
  • Move const toasts: Toasts = { ... } to Events/asyncToasts.tsx.
  • Map to event messages already defined in our new factory.

Target release date ๐Ÿ—“๏ธ

N/A

How to test ๐Ÿงช

Verification steps

  • Verify all the async toasts continue to work as expected.
  • Confirm formatting and displaying of messages.

As an Author I have considered ๐Ÿค”

Check all that apply

  • [x] ๐Ÿ‘€ Doing a self review
  • [x] โ” Our contribution guidelines
  • [x] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

pmakode-akamai avatar Aug 27 '24 12:08 pmakode-akamai

Coverage Report: โœ…
Base Coverage: 86.2%
Current Coverage: 86.2%

github-actions[bot] avatar Aug 27 '24 13:08 github-actions[bot]

@pmakode-akamai Hey Purvesh, just a heads up that this PR seems to be causing a handful of test failures -- at a glance they seem to be caused by toast notifications for certain events not appearing when Cloud expects them to appear

jdamore-linode avatar Aug 28 '24 14:08 jdamore-linode

@pmakode-akamai Hey Purvesh, just a heads up that this PR seems to be causing a handful of test failures -- at a glance they seem to be caused by toast notifications for certain events not appearing when Cloud expects them to appear

Hey Joe (@jdamore-linode), this PR is still WIP. Iโ€™ll be looking into the test failures related to the toast notifications and will address them soon. Thanks!

pmakode-akamai avatar Aug 28 '24 15:08 pmakode-akamai