manager
manager copied to clipboard
refactor: [M3-8331] - useToastNotification async toasts
Description ๐
const toasts: Toasts = { ... } ย should be moved to the event directory and map to event messages already defined in our new factory
Changes ๐
- Refactor
useToastNotification. - Move
const toasts: Toasts = { ... }toEvents/asyncToasts.tsx. - Map to event messages already defined in our new factory.
Target release date ๐๏ธ
N/A
How to test ๐งช
Verification steps
- Verify all the async toasts continue to work as expected.
- Confirm formatting and displaying of messages.
As an Author I have considered ๐ค
Check all that apply
- [x] ๐ Doing a self review
- [x] โ Our contribution guidelines
- [x] ๐ค Splitting feature into small PRs
- [x] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 86.2%
Current Coverage: 86.2%
@pmakode-akamai Hey Purvesh, just a heads up that this PR seems to be causing a handful of test failures -- at a glance they seem to be caused by toast notifications for certain events not appearing when Cloud expects them to appear
@pmakode-akamai Hey Purvesh, just a heads up that this PR seems to be causing a handful of test failures -- at a glance they seem to be caused by toast notifications for certain events not appearing when Cloud expects them to appear
Hey Joe (@jdamore-linode), this PR is still WIP. Iโll be looking into the test failures related to the toast notifications and will address them soon. Thanks!