fix: [M3-8492] - Create Linode Firewall warning not appearing

[hkhalil-akamai]

Description 📝

Fixes a bug causing the Firewall warning to not appear after the user assigns and then clears the firewall select during the create flow.

Changes 🔄

• Update the firewall_id interface in CreateLinodePayload to not accept null values (i.e., number | undefined)
• Refactor SelectFirewallPanel and associated types in Create v1 to use undefined instead of -1 when the firewall field is cleared
• Remove a redundant useEffect

Target release date 🗓️

9/3

Preview 📷

Before	After
Create v2
Create v1

How to test 🧪

Prerequisites

Enable Secure VM notices by adding secure_vm_notices: 'always' in the preference editor.

Reproduction steps

• Select and then clear the firewall field in the Linode Create flows (v1 and v2)
• Click the "Create Linode" button
• Observe that the Firewall authorization warning banner does not appear
  • In Create v1, the form is submitted and the Linode is created
  • In Create v2, the Create Linode button becomes disabled

Verification steps

• Follow the reproduction steps
• Verify that the Firewall authorization banner always appears after clicking the Create Linode button when no firewall is assigned

[github-actions[bot]]

Coverage Report: ✅
Base Coverage: 82.73%
Current Coverage: 82.74%