manager icon indicating copy to clipboard operation
manager copied to clipboard

fix: [M3-7305] - Correct Object Storage folder links containing special characters

Open skulpok-akamai opened this issue 1 year ago โ€ข 2 comments

Description ๐Ÿ“

Object Storage bucket folders containing URL special characters could not be opened. After the change, their links navigate to a correct location.

Changes ๐Ÿ”„

List any change relevant to the reviewer.

  • Special characters in folder links are URI-encoded.

Target release date ๐Ÿ—“๏ธ

Any release

Preview ๐Ÿ“ท

Before After
image image

How to test ๐Ÿงช

  1. Create a folder containing special characters, e.g:

s3cmd put ./Test.txt s3://sk-test/dir+with+pluses/Test.txt

  1. Open that folder in Cloud Manager

When opened, the folder should contain Test.txt file.

As an Author I have considered ๐Ÿค”

Check all that apply

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

skulpok-akamai avatar Aug 23 '24 12:08 skulpok-akamai

Coverage Report: โœ…
Base Coverage: 82.73%
Current Coverage: 82.87%

github-actions[bot] avatar Aug 23 '24 17:08 github-actions[bot]

I just noticed that I have a wrong import for TableRowProps. I'm doing a commit with the corrected import.

skulpok-akamai avatar Aug 26 '24 07:08 skulpok-akamai