manager
manager copied to clipboard
fix: [M3-8142] - Alignment Regression Of The IP Address Inside Node Pools Table
Description ๐
Fixes the the vertical alignment of the IP Address inside of the Node Pools table.
Changes ๐
List any change relevant to the reviewer.
- For testing purposes, I disabled the
background-color: transparentcss property on thecopyicon in order to show the cause of the visual bug. - ~~Updated the row width percentage values, allowing the
IP Addresscolumn more room since some addresses will cause the text to wrap. TheStatuscolumn does not need as much room and the values in these change maintain a similar proportion as before.~~ - Pass the
noWrapprop set totrueon the<TableCell>for the IP Address column to prevent longer addresses from wrapping thecopyicon and resulting in vertical alignment discrepancies.
Preview ๐ท
| Before | After |
|---|---|
How to test ๐งช
- Open the web browser developer tools and modify the viewport width as shown in the
Previewvideo to ensure consistent results.
Verification steps
(How to verify changes)
- Verify that as you adjust the viewport width, the IP Address which are wider than normal do not cause the copy icon to wrap to the next line (causing the IP Address to shift vertically).
As an Author I have considered ๐ค
Check all that apply
- [x] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [x] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 82.24%
Current Coverage: 82.18%