manager icon indicating copy to clipboard operation
manager copied to clipboard

fix: [M3-8142] - Alignment Regression Of The IP Address Inside Node Pools Table

Open carrillo-erik opened this issue 1 year ago โ€ข 1 comments

Description ๐Ÿ“

Fixes the the vertical alignment of the IP Address inside of the Node Pools table.

Changes ๐Ÿ”„

List any change relevant to the reviewer.

  • For testing purposes, I disabled the background-color: transparent css property on the copy icon in order to show the cause of the visual bug.
  • ~~Updated the row width percentage values, allowing the IP Address column more room since some addresses will cause the text to wrap. The Status column does not need as much room and the values in these change maintain a similar proportion as before.~~
  • Pass the noWrap prop set to true on the <TableCell> for the IP Address column to prevent longer addresses from wrapping the copy icon and resulting in vertical alignment discrepancies.

Preview ๐Ÿ“ท

Before After

How to test ๐Ÿงช

  • Open the web browser developer tools and modify the viewport width as shown in the Preview video to ensure consistent results.

Verification steps

(How to verify changes)

  • Verify that as you adjust the viewport width, the IP Address which are wider than normal do not cause the copy icon to wrap to the next line (causing the IP Address to shift vertically).

As an Author I have considered ๐Ÿค”

Check all that apply

  • [x] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

carrillo-erik avatar Jun 20 '24 22:06 carrillo-erik

Coverage Report: โŒ
Base Coverage: 82.24%
Current Coverage: 82.18%

github-actions[bot] avatar Jun 20 '24 22:06 github-actions[bot]