manager icon indicating copy to clipboard operation
manager copied to clipboard

upcoming: [M3-8217] - Tax Id Notifications & Icon

Open jaalah-akamai opened this issue 1 year ago • 3 comments

Description 📝

New notifications for Tax Id

Changes 🔄

  • Add two new notifications when tax id is valid/invalid
  • Add warning icon next to tax id in billing section

Target release date 🗓️

7/8

Preview 📷

Desc SS
Notifications Screenshot 2024-06-26 at 8 56 23 AM
Billing Section Screenshot 2024-06-07 at 12 57 34 PM

How to test 🧪

Prerequisites

  • If you want to test the events part of this, you'll need to setup DevEnv (see me about details)
  • Otherwise, you can locally comment out the rendering conditions for the TooltipIcon

Validation

  • Checkout this branch in devenv
  • Checkout latest develop branch of apinext in devenv
  • Add a row to the TaxValidation table with format_valid set to 1, and tax_registered to yes.
  • curl /account/notifications and notice the tax_id_valid notification.
  • Set format_valid to 0, and curl /account/notifications again, notice tax_id_invalid notification. Try again with format_valid set to 1, and tax_registered set to no.

jaalah-akamai avatar Jun 07 '24 21:06 jaalah-akamai

Coverage Report:
Base Coverage: 82.31%
Current Coverage: 82.31%

github-actions[bot] avatar Jun 27 '24 19:06 github-actions[bot]

I need to fix some invalidation issues with RQ - please hold

jaalah-akamai avatar Jun 27 '24 21:06 jaalah-akamai

Devenv has been having issues all day preventing me from e2e testing this - I will wait until things are back up and re-request reviews.

jaalah-akamai avatar Jun 28 '24 19:06 jaalah-akamai