manager icon indicating copy to clipboard operation
manager copied to clipboard

fix: Cypress test creating an Image without a `cy-test` prefixed label

Open bnussman-akamai opened this issue 1 year ago โ€ข 1 comments

Description ๐Ÿ“

  • I made a mistake in https://github.com/linode/manager/pull/10471 (specifically here)
  • I removed the randomLabel() from the createImage call because at the time, it didn't occur to me that the image label mattered for the sake of the test. I was correct in that sense, but I failed to remember that cypress only cleans up entities that are prefixed with cy-test ๐Ÿคฆ . Our test accounts are filling up with Images that are not being cleaned up as a result ๐Ÿ˜ฃ
  • This PR adds back the randomLabel() so the image is created with a label that will be cleaned up

How to test ๐Ÿงช

  • Verify the image created by create-stackscripts.spec.ts are prefixed with cy-test

As an Author I have considered ๐Ÿค”

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [ ] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

bnussman-akamai avatar May 22 '24 23:05 bnussman-akamai

Coverage Report: โœ…
Base Coverage: 81.64%
Current Coverage: 81.64%

github-actions[bot] avatar May 22 '24 23:05 github-actions[bot]