manager
manager copied to clipboard
fix: Cypress test creating an Image without a `cy-test` prefixed label
Description ๐
- I made a mistake in https://github.com/linode/manager/pull/10471 (specifically here)
- I removed the
randomLabel()from thecreateImagecall because at the time, it didn't occur to me that the image label mattered for the sake of the test. I was correct in that sense, but I failed to remember that cypress only cleans up entities that are prefixed withcy-test๐คฆ . Our test accounts are filling up with Images that are not being cleaned up as a result ๐ฃ - This PR adds back the
randomLabel()so the image is created with a label that will be cleaned up
How to test ๐งช
- Verify the image created by
create-stackscripts.spec.tsare prefixed withcy-test
As an Author I have considered ๐ค
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 81.64%
Current Coverage: 81.64%