manager icon indicating copy to clipboard operation
manager copied to clipboard

change: [M3 7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint

Open carrillo-erik opened this issue 1 year ago โ€ข 1 comments

Description ๐Ÿ“

The changes in this PR replace the hardcoded price values for LKE High Availability with the data from the lke/types endpoint.

Changes ๐Ÿ”„

List any change relevant to the reviewer.

  • Removal of the LK_HA_PRICE const.
  • Replacement of outstanding default imports with named imports.
  • ClusterDetail is renamed to KubernetesClusterDetail.
  • New kubernetesTypeFactory type factory and corresponding tests.
  • New DC Specific Pricing queries for Kubernetes (LKE HA).
  • New lke/types API endpoint.

How to test ๐Ÿงช

  • Go through the normal Kubernetes Create workflow.

Verification steps

(How to verify changes)

  • Verify that existing LKE create workflows behave as expected.
  • Verify that switching between different regions changes the price. In particular Jakarta, ID (id-cgk) and Sao Paulo, BR (br-gru) should update the price for LKE HA from $60.00 to $72.00 and $84.00, respectively.
  • Verify that the total price reflects the LKE HA selection based on the appropriate region.
  • Verify there are no visual regressions as a result of these changes.

As an Author I have considered ๐Ÿค”

Check all that apply

  • [x] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [x] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [x] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

carrillo-erik avatar May 22 '24 17:05 carrillo-erik

Coverage Report: โœ…
Base Coverage: 82.85%
Current Coverage: 83.08%

github-actions[bot] avatar May 22 '24 17:05 github-actions[bot]

Please Note:

Aside from resolving the merge conflicts, there's some optimizations that need to be implemented. There were additional use cases discovered and I'm waiting for input from UX on how to address them. For now, I've labeled this PR as Work in Progress.

carrillo-erik avatar May 28 '24 13:05 carrillo-erik

~~@carrillo-erik can we resolve the conflict before review?~~

nevermind, just saw the comment above. Maybe back into draft until ready to be reviewed?

abailly-akamai avatar May 29 '24 15:05 abailly-akamai

@carrillo-erik i believe the e2e failure also is relevant here, you do want to fix it before merging

abailly-akamai avatar Jun 11 '24 14:06 abailly-akamai

@abailly-akamai @mjac0bs There's been a few updates to this PR and it continually got bigger (although the changes were minimal). I'm more than happy to schedule a pair review session before merging this PR.

carrillo-erik avatar Jun 14 '24 12:06 carrillo-erik

@carrillo-erik you have to fix conflicts and address feedback before this gets out of date again

abailly-akamai avatar Jun 18 '24 13:06 abailly-akamai

@carrillo-erik you have to fix conflicts and address feedback before this gets out of date again

@abailly-akamai I've pushed my recent changes addressing the feedback.

carrillo-erik avatar Jun 18 '24 14:06 carrillo-erik