manager
manager copied to clipboard
change: [M3 7383] - Replace hardcoded prices for LKE HA with data from `lke/types` API endpoint
Description ๐
The changes in this PR replace the hardcoded price values for LKE High Availability with the data from the lke/types endpoint.
Changes ๐
List any change relevant to the reviewer.
- Removal of the
LK_HA_PRICEconst. - Replacement of outstanding
default importswithnamed imports. ClusterDetailis renamed toKubernetesClusterDetail.- New
kubernetesTypeFactorytype factory and corresponding tests. - New DC Specific Pricing queries for Kubernetes (LKE HA).
- New
lke/typesAPI endpoint.
How to test ๐งช
- Go through the normal Kubernetes Create workflow.
Verification steps
(How to verify changes)
- Verify that existing LKE create workflows behave as expected.
- Verify that switching between different regions changes the price. In particular
Jakarta, ID (id-cgk)andSao Paulo, BR (br-gru)should update the price forLKE HAfrom $60.00 to $72.00 and $84.00, respectively. - Verify that the total price reflects the
LKE HAselection based on the appropriate region. - Verify there are no visual regressions as a result of these changes.
As an Author I have considered ๐ค
Check all that apply
- [x] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [x] โ Adding a changeset
- [x] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [x] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 82.85%
Current Coverage: 83.08%
Please Note:
Aside from resolving the merge conflicts, there's some optimizations that need to be implemented. There were additional use cases discovered and I'm waiting for input from UX on how to address them. For now, I've labeled this PR as Work in Progress.
~~@carrillo-erik can we resolve the conflict before review?~~
nevermind, just saw the comment above. Maybe back into draft until ready to be reviewed?
@carrillo-erik i believe the e2e failure also is relevant here, you do want to fix it before merging
@abailly-akamai @mjac0bs There's been a few updates to this PR and it continually got bigger (although the changes were minimal). I'm more than happy to schedule a pair review session before merging this PR.
@carrillo-erik you have to fix conflicts and address feedback before this gets out of date again
@carrillo-erik you have to fix conflicts and address feedback before this gets out of date again
@abailly-akamai I've pushed my recent changes addressing the feedback.