feat: [M3-8023] - Refactor Image Upload and Add Tags
Description ๐
- Refactors the Image Upload page and related components ๐งน
- Use react-hook-form to provide realtime validation โ๏ธ
- Implements new UI based on Image Service gen2 mockups ๐จ
- Adds tags to the Image Upload page ๐ท๏ธ
- Improves drag-drop styles ๐จ
- Adds a
Create Imagebutton ๐ (previously, the upload would begin when the upload was selected)
Preview ๐ท
| Before | After |
|---|---|
How to test ๐งช
- Test all functionality related to the Image Upload page ๐
- Verify you can upload an image
- Verify validation works
- Verify you can't navigate to a different page when an upload is in progress
- Compare this new flow to the existing flow and look for oversights/regressions
[!note] Don't have an Image to upload? This is how I generate a gziped image:
- Download an image from https://alpinelinux.org/downloads/
- In your terminal run
gzip alpine-standard-3.19.1-x86_64.iso.gz- Upload that Image
As an Author I have considered ๐ค
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [x] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 81.73%
Current Coverage: 82.28%
@bnussman-akamai looks great! can you confirm all changes with UX before doing a deep dive review?
Great feedback @mjac0bs. I'm checking with UX on the Upload Using Command Line change
AlI changes have been reviewed and approved by UX ๐
The "Upload Using Command Line" change was made @mjac0bs
Going to check with UX on the region helper text and the two papers @abailly-akamai The broken Toast issue is out of scope of this work.
Lol everything was kinda out of scope
@abailly-akamai Noting that we do have a ticket for the broken toast close already (M3-8052).
Thanks for checking with UX and confirming those improvements, @bnussman-akamai!
Awesome rework - thanks for spending the time on this ๐
something funky with the pipeline again ๐ค
@abailly-akamai UX confirmed they want to keep the separate papers. They provided some updated helper text for the region select. They requested it goes above the input instead of below