manager icon indicating copy to clipboard operation
manager copied to clipboard

feat: [M3-8023] - Refactor Image Upload and Add Tags

Open bnussman-akamai opened this issue 1 year ago โ€ข 7 comments

Description ๐Ÿ“

  • Refactors the Image Upload page and related components ๐Ÿงน
    • Use react-hook-form to provide realtime validation โ˜‘๏ธ
  • Implements new UI based on Image Service gen2 mockups ๐ŸŽจ
  • Adds tags to the Image Upload page ๐Ÿท๏ธ
  • Improves drag-drop styles ๐ŸŽจ
  • Adds a Create Image button ๐Ÿ”˜ (previously, the upload would begin when the upload was selected)

Preview ๐Ÿ“ท

Before After
Screenshot 2024-05-17 at 3 10 09โ€ฏPM Screenshot 2024-05-17 at 3 09 00โ€ฏPM

How to test ๐Ÿงช

  • Test all functionality related to the Image Upload page ๐Ÿ‘€
    • Verify you can upload an image
    • Verify validation works
    • Verify you can't navigate to a different page when an upload is in progress
    • Compare this new flow to the existing flow and look for oversights/regressions

[!note] Don't have an Image to upload? This is how I generate a gziped image:

  1. Download an image from https://alpinelinux.org/downloads/
  2. In your terminal run gzip alpine-standard-3.19.1-x86_64.iso.gz
  3. Upload that Image

As an Author I have considered ๐Ÿค”

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

bnussman-akamai avatar May 17 '24 16:05 bnussman-akamai

Coverage Report: โœ…
Base Coverage: 81.73%
Current Coverage: 82.28%

github-actions[bot] avatar May 17 '24 19:05 github-actions[bot]

@bnussman-akamai looks great! can you confirm all changes with UX before doing a deep dive review?

abailly-akamai avatar May 20 '24 13:05 abailly-akamai

Great feedback @mjac0bs. I'm checking with UX on the Upload Using Command Line change

bnussman-akamai avatar May 22 '24 15:05 bnussman-akamai

AlI changes have been reviewed and approved by UX ๐ŸŽ‰

The "Upload Using Command Line" change was made @mjac0bs

Going to check with UX on the region helper text and the two papers @abailly-akamai The broken Toast issue is out of scope of this work.

bnussman-akamai avatar May 23 '24 13:05 bnussman-akamai

Lol everything was kinda out of scope

abailly-akamai avatar May 23 '24 13:05 abailly-akamai

@abailly-akamai Noting that we do have a ticket for the broken toast close already (M3-8052).

Thanks for checking with UX and confirming those improvements, @bnussman-akamai!

mjac0bs avatar May 23 '24 14:05 mjac0bs

Awesome rework - thanks for spending the time on this ๐Ÿ‘

something funky with the pipeline again ๐Ÿค”

abailly-akamai avatar May 23 '24 14:05 abailly-akamai

@abailly-akamai UX confirmed they want to keep the separate papers. They provided some updated helper text for the region select. They requested it goes above the input instead of below

bnussman-akamai avatar May 28 '24 13:05 bnussman-akamai