manager icon indicating copy to clipboard operation
manager copied to clipboard

refactor: [M3-8043] - Query Key Factory for Volumes

Open bnussman-akamai opened this issue 1 year ago โ€ข 1 comments

Description ๐Ÿ“

Refactors Volume Queries

Changes ๐Ÿ”„

  • Performs some slight organization ๐Ÿ—„๏ธ
  • Uses a query key factory for volume queries ๐Ÿญ
  • Addresses the "single object notation" breaking change in preportion for v5 (https://tanstack.com/query/v5/docs/framework/react/guides/migrating-to-v5#supports-a-single-signature-one-object)

Preview ๐Ÿ“ท

[!note] No UI changes

How to test ๐Ÿงช

  • Verify all Volume create, update, delete work the same as the previously did
  • Verify all automated testing for volumes pass

As an Author I have considered ๐Ÿค”

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [ ] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

bnussman-akamai avatar Apr 26 '24 21:04 bnussman-akamai

Coverage Report: โœ…
Base Coverage: 81.82%
Current Coverage: 81.82%

github-actions[bot] avatar Apr 26 '24 22:04 github-actions[bot]

Manually tested the Volumes functionality across the application and did not experience any issues. No issues with C/I pipelines. Overall it's a good refactor of the existing queries that will serve as an example for future refactors using the query key factory pattern.

carrillo-erik avatar Apr 30 '24 20:04 carrillo-erik