manager
manager copied to clipboard
upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager
Description ๐
Added a CloudPulseTab component Added a dashboard landing component Added a RegionSelect component Added a TimeRange component Added a Global Filters component to manage the filters
Changes ๐
List any change relevant to the reviewer.
- Added a CloudPulseTab component
- Added a dashboard landing component
- Added a RegionSelect component
- Added a TimeRange component
- Added a Global Filters component to manage the filters
Preview ๐ท
Include a screenshot or screen recording of the change
:bulb: Use <video src="" /> tag when including recordings in table.
| Before | After |
|---|---|
How to test ๐งช
Prerequisites
(How to setup test environment)
- Follow cloud manager standard procedures
Reproduction steps
(How to reproduce the issue, if applicable)
- N/A
Verification steps
(How to verify changes)
- Navigate to cloud manager and once feature flag of CloudPulse is enabled then navigate to the Monitor section in the sidebar for the CloudPulse section.
- There the added two global filters options are visible, can be used to select the respective options for both the RegionSelect and TimeRange
As an Author I have considered ๐ค
Check all that apply
- [x] ๐ Doing a self review
- [x] โ Our contribution guidelines
- [x] ๐ค Splitting feature into small PRs
- [x] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [x] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 82.28%
Current Coverage: 82.29%
Before I approve this I need some context.
Are you just stubbing this in? If you are, this is fine, with the exception of changing the "2024" value in the time drop down to "Year to date".
If you're not stubbing this in, I need to see the UX design you're referencing, because what you have is pretty rough.
For the 1st phase we are going with basic user journey functionalities utilizing the cloud manager components. This eventually will have a revised versions as we progressed. Regarding the dates, we will remove the years from that, as we will support only max of 30 days duration only
Thank you, @jaalah-akamai .Can I mark those conversations as resolved ?
@santoshp210 Just a heads up that merging in the latest changes from develop should resolve your test failure