manager icon indicating copy to clipboard operation
manager copied to clipboard

upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager

Open santoshp210 opened this issue 1 year ago โ€ข 2 comments

Description ๐Ÿ“

Added a CloudPulseTab component Added a dashboard landing component Added a RegionSelect component Added a TimeRange component Added a Global Filters component to manage the filters

Changes ๐Ÿ”„

List any change relevant to the reviewer.

  • Added a CloudPulseTab component
  • Added a dashboard landing component
  • Added a RegionSelect component
  • Added a TimeRange component
  • Added a Global Filters component to manage the filters

Preview ๐Ÿ“ท

Include a screenshot or screen recording of the change

:bulb: Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2024-04-22 at 19 55 04 Screenshot 2024-04-23 at 17 52 03
Screenshot 2024-04-22 at 19 55 04 Screenshot 2024-04-23 at 17 51 51

How to test ๐Ÿงช

Prerequisites

(How to setup test environment)

  • Follow cloud manager standard procedures

Reproduction steps

(How to reproduce the issue, if applicable)

  • N/A

Verification steps

(How to verify changes)

  • Navigate to cloud manager and once feature flag of CloudPulse is enabled then navigate to the Monitor section in the sidebar for the CloudPulse section.
  • There the added two global filters options are visible, can be used to select the respective options for both the RegionSelect and TimeRange

As an Author I have considered ๐Ÿค”

Check all that apply

  • [x] ๐Ÿ‘€ Doing a self review
  • [x] โ” Our contribution guidelines
  • [x] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [x] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

santoshp210 avatar Apr 23 '24 12:04 santoshp210

Coverage Report: โœ…
Base Coverage: 82.28%
Current Coverage: 82.29%

github-actions[bot] avatar Apr 23 '24 15:04 github-actions[bot]

Before I approve this I need some context.

Are you just stubbing this in? If you are, this is fine, with the exception of changing the "2024" value in the time drop down to "Year to date".

If you're not stubbing this in, I need to see the UX design you're referencing, because what you have is pretty rough.

For the 1st phase we are going with basic user journey functionalities utilizing the cloud manager components. This eventually will have a revised versions as we progressed. Regarding the dates, we will remove the years from that, as we will support only max of 30 days duration only

kmuddapo avatar Apr 25 '24 07:04 kmuddapo

Thank you, @jaalah-akamai .Can I mark those conversations as resolved ?

santoshp210 avatar May 28 '24 11:05 santoshp210

@santoshp210 Just a heads up that merging in the latest changes from develop should resolve your test failure

jdamore-linode avatar May 28 '24 14:05 jdamore-linode