manager
manager copied to clipboard
upcoming: [M3-7615] - Add placement group to payload
Description ๐
The main concept with this PR is to include the details of the selected Placement Group as part of the Create Linode workflow.
Changes ๐
List any change relevant to the reviewer.
- The
LabelAndTagsPanelhas been renamed toDetailsPanelsince the panel had been updated to include thePlacementGroupSelectcomponent. Accordingly, theDetailstitle has been added to the panel. - If the selected
PlacementGroupdoes not have any capacity, an errorNoticeis displayed within the panel. - Updates to the Linodes schema to include
Placement Groupdetails.
Preview ๐ท
How to test ๐งช
(How to setup test environment)
- Enable the following using the Cloud Manager Dev Tools:
- Placement Groups feature flag
- MSW
Verification steps
Success
- Go through the
Create Linodeworkflow and selectNewark, NJ (us-east)for theRegion. - Select any of the listed
Placement Groups. - Complete the remaining fields and click on the
Create Linodebutton. - Verify that the request was successful.
Error
- Update the
placementGroupFactoryby adding an additional element to thelinode_idsarray. This will make thePlacement Groupbe at full capacity. - Go through the
Create Linodeworkflow as above. - Verify that clicking on the
Create Linodebutton results in an error and theNoticeis displayed.
As an Author I have considered ๐ค
Check all that apply
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 81.24%
Current Coverage: 81.24%
- The placement_group payload is still sent when the flag is OFF, which we want to avoid
@abailly-akamai
This makes sense, however, if the feature flag is OFF; should the value of placement_group be null or undefined?
@carrillo-erik it should be undefined, because this key does not exist in the upstream schema
@carrillo-erik When the error appears the tooltip icon shifts down. We should remove the tooltip icon here and just pass textFieldProps to <PlacementGroupsSelect />:
textFieldProps={{tooltipText}}
Obviously when you call the underlying <Autocomplete /> component you'll need to spread the props there {...textFieldProps} and maybe even add a tooltipText prop to the <TextField /> component itself in Autocomplete.tsx.