linode-cli icon indicating copy to clipboard operation
linode-cli copied to clipboard

depends on enum34, even for python3

Open ryantm opened this issue 6 years ago • 2 comments

I was trying to package linode-cli for NixOS and I noticed a couple issues with the release artifacts. I'll post a separate issues about them.

The wheel archive metadata.json file says that run_requires enum34, but it looks like enum34 is only targeting a sub-set of the python versions this project is targeting. I'm not that familiar with how wheel archive metadata works, but it would be nice if it could be specified that enum34 is only necessary for python2 or whatever.

ryantm avatar Jun 07 '18 21:06 ryantm

Thanks for brining this up, I'll look into it and see what actually requires it. I believe you're correct in that it's only relevant for python2

Dorthu avatar Jun 11 '18 14:06 Dorthu

I encountered the same issue packaging linode-cli for Arch Linux. The end result was a failure to run under python3.7 due to enum34 not being present.

I ended up patching during the build to modify requirements.txt and setup.py with the following to get it to work:

requirements.txt

terminaltables
colorclass
requests
PyYAML
enum34; python_version < '3.4'

setup.py

install_requires=["terminaltables","colorclass","requests","PyYAML"],
extras_require={
    ":python_version<'3.4'": ['enum34'],
},

cmorgenstern avatar Mar 25 '19 01:03 cmorgenstern

Closing since it looks like this issue is resolved. Feel free to @ me if this issue is still valid.

lgarber-akamai avatar Nov 10 '22 16:11 lgarber-akamai