linode-blockstorage-csi-driver icon indicating copy to clipboard operation
linode-blockstorage-csi-driver copied to clipboard

chore: return notFound when disk isn't attached

Open guilhem opened this issue 10 months ago • 2 comments

https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/5a645a4b2fe29a52bba3305365c5918d049f1cf0/pkg/csi/service/osutils/linux_os_utils.go#L870

General:

  • [ ] Have you removed all sensitive information, including but not limited to access keys and passwords?
  • [ ] Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue

guilhem avatar Mar 11 '25 13:03 guilhem

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.18%. Comparing base (685e341) to head (a4c1f2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   73.11%   73.18%   +0.07%     
==========================================
  Files          23       23              
  Lines        2648     2648              
==========================================
+ Hits         1936     1938       +2     
+ Misses        585      583       -2     
  Partials      127      127              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 11 '25 14:03 codecov[bot]

⚠️ spec is unclear about what to do here. Looking at kubernetes code, both return have same action. This PR could be ignored for now

guilhem avatar Mar 12 '25 10:03 guilhem