linode-blockstorage-csi-driver
linode-blockstorage-csi-driver copied to clipboard
chore: return notFound when disk isn't attached
https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/5a645a4b2fe29a52bba3305365c5918d049f1cf0/pkg/csi/service/osutils/linux_os_utils.go#L870
General:
- [ ] Have you removed all sensitive information, including but not limited to access keys and passwords?
- [ ] Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?
Pull Request Guidelines:
- [ ] Does your submission pass tests?
- [ ] Have you added tests?
- [ ] Are you addressing a single feature in this PR?
- [ ] Are your commits atomic, addressing one change per commit?
- [ ] Are you following the conventions of the language?
- [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
- [ ] Have you explained your rationale for why this feature is needed?
- [ ] Have you linked your PR to an open issue
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.18%. Comparing base (
685e341) to head (a4c1f2f).
Additional details and impacted files
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 73.11% 73.18% +0.07%
==========================================
Files 23 23
Lines 2648 2648
==========================================
+ Hits 1936 1938 +2
+ Misses 585 583 -2
Partials 127 127
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
⚠️ spec is unclear about what to do here. Looking at kubernetes code, both return have same action. This PR could be ignored for now