linode-blockstorage-csi-driver icon indicating copy to clipboard operation
linode-blockstorage-csi-driver copied to clipboard

minor documentation updates to development and test experience

Open amold1 opened this issue 1 year ago • 1 comments

General:

  • [ ] Have you removed all sensitive information, including but not limited to access keys and passwords?
  • [ ] Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue

amold1 avatar Sep 24 '24 18:09 amold1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.08%. Comparing base (02c9b18) to head (06756ec). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   49.59%   53.08%   +3.49%     
==========================================
  Files          22       22              
  Lines        1587     1588       +1     
==========================================
+ Hits          787      843      +56     
+ Misses        750      700      -50     
+ Partials       50       45       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 24 '24 18:09 codecov[bot]

LTGM!

But could you also add some documentation about different labels you added to chainsaw tests and we can use E2E_SELECTOR env var to select? It would be valuable to document that and make it easily accessible for others!

done!

amold1 avatar Sep 25 '24 12:09 amold1