cluster-api-provider-linode
cluster-api-provider-linode copied to clipboard
[fix] fix etcd-backup-restore based flavors
What this PR does / why we need it: CAPL clusterrs with etcd-backup-restore and related flavors fail to created. This is down to some recent OBJ changes for key names and namespaces within the secrets.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.33%. Comparing base (
98b4e79) to head (20ede2e). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 65.33% 65.33%
=======================================
Files 80 80
Lines 4192 4192
=======================================
Hits 2739 2739
Misses 1243 1243
Partials 210 210
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM. Just a question @bcm820 for my understanding, the keys and bucket can be in different namespaces? From the PR I see, the secrets of type=addons.cluster.x-k8s.io/resource-set should always be created in namespace=kube-system. Was there any specific reason why it was removed in the first place?
LGTM. Just a question @bcm820 for my understanding, the keys and bucket can be in different namespaces? From the PR I see, the secrets of type=addons.cluster.x-k8s.io/resource-set should always be created in namespace=kube-system. Was there any specific reason why it was removed in the first place?
That is hard-coded because that secret is only meant for backup-restore and the backup-restore pod is hardcoded to be in the kube-system namespace