cluster-api-provider-linode icon indicating copy to clipboard operation
cluster-api-provider-linode copied to clipboard

remove duplicate cilium helmchart

Open eljohnson92 opened this issue 1 year ago • 2 comments

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

TODOs:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests
  • [ ] adds or updates e2e tests

eljohnson92 avatar May 03 '24 20:05 eljohnson92

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.18%. Comparing base (0ff8a1c) to head (2444308). Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   64.87%   66.18%   +1.31%     
==========================================
  Files          30       30              
  Lines        1842     1872      +30     
==========================================
+ Hits         1195     1239      +44     
+ Misses        592      575      -17     
- Partials       55       58       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 20:05 codecov[bot]

~~I don't see k3s clusters getting provisioned after this change. Not sure if its working on your end.~~ Checking again on my end.

Seeing following error:

k describe machine k3s-control-plane-wxzxt

Status:
  Conditions:
    Last Transition Time:  2024-05-03T23:15:41Z
    Message:               0 of 2 completed
    Reason:                DataSecretGenerationFailed
    Severity:              Warning
    Status:                False
    Type:                  Ready
    Last Transition Time:  2024-05-03T23:15:41Z
    Message:               failed to resolve file source: secret references non-existent secret key "cilium.yaml": invalid reference
    Reason:                DataSecretGenerationFailed
    Severity:              Warning
    Status:                False

We are referencing it here: https://github.com/linode/cluster-api-provider-linode/blob/main/templates/flavors/k3s/k3sControlPlane.yaml#L18-L23

rahulait avatar May 03 '24 23:05 rahulait

I've updated the scope of this to keep rke2/k3s inline with eachother but this should now all be working

eljohnson92 avatar May 06 '24 18:05 eljohnson92