concourse-helm-resource icon indicating copy to clipboard operation
concourse-helm-resource copied to clipboard

Add support for Helmfile

Open mikelorant opened this issue 4 years ago • 2 comments

Implemented helmfile support. Improvements have been added to the original work from https://github.com/QuoineFinancial/concourse-helmfile-resource.

Extra functionality or fixes:

  • Add support for helmfile.d with auto detection.
  • Helmfile command is settable.
  • Upgraded helmfile version.
  • Params under helmfile key.
  • Prefixed helmfile specific variables for clarity.
  • Fixed early execution of helmfile.

Other improvements unrelated to Helmfile support:

  • Improved Dockerfile to add plugins before file assets to speed up build.
  • Switch back to alpine Helm release and downgrade for better compatibility.
  • Fixed references to helm when they should be using the helm_bin variable.

Have concerns about the meaning of the result as it is specific to a helm release and a helmfile can have many releases in it. Have not changed this logic and it continues to work as originally designed.

mikelorant avatar May 03 '20 21:05 mikelorant

Hey, thanks so much! I really do like the helmfile support but I'm a bit unsure if it makes sense to have both things in the same resource of if we'd be better of splitting it into two resources: one for helmfile support and another one for plain helm. I mean apart from the kubernetes-cluster connection they don't have that much in common anymore.

What are your thoughts about that?

msiegenthaler avatar May 14 '20 08:05 msiegenthaler

I agree that in some ways it should be split, but there was so much in common it was easy to add without too much extra code. Also, Helmfile with Concourse is a much better solution than directly calling Helm. Much of the Concourse configuration can be simplified into a simpler helmfile.

Something for you to ponder, maybe others may share feedback.

mikelorant avatar May 16 '20 04:05 mikelorant