linkml icon indicating copy to clipboard operation
linkml copied to clipboard

`linkml-ws` followup: `make setup`: `poetry: command not found`

Open joeflack4 opened this issue 3 years ago • 2 comments

Describe the bug I'm following the steps in this video to set up a new LinkML project using linkml-ws.

To Reproduce Steps to reproduce the behavior:

  1. Create an empty directory in which to create project.
  2. (~optional) Make a virtual environment
  3. pip install linkml
  4. Try to create a new LinkML workspace using: linmkl-ws new -D "<WORKSPACE_NAME>" <WORKSPACE_NAME>
  5. cd <WORKSPACE_NAME>
  6. make setup

Expected behavior Project should be set up.

Actual behavior

make setup
poetry install
bash: poetry: command not found
make: *** [install] Error 127

Things I tried

  1. Making sure LinkML is installed.
pip freeze | grep linkml
biolinkml==1.7.6
linkml==1.2.10
linkml-dataops==0.1.0
linkml-runtime==1.2.9
linmkl-ws new -D "tccm"
zsh: command not found: linmkl-ws

Possible solutions

  1. Making sure that the following is included as an argument to setup() in setup.py:
      install_requires=[
          'poetry',
      ],

joeflack4 avatar May 06 '22 19:05 joeflack4

@joeflack4: you can see the repo no longer uses setuptools and pipenv for package management. We could have documented this better, but you can install the poetry binaries on your machine, and not as a python package, by following the instructions here: https://python-poetry.org/docs/

sujaypatil96 avatar May 16 '22 17:05 sujaypatil96

I am aware now, thanks Sujay. I discussed briefly w/ Chris during a LinkML meeting. He understands the UX argument I'm making. I think probably some automation can be done for the edge case where a random user on the internet wants to pick up LinkML, but isn't using poetry. But it is probably not worth the dev time anyway to handle that case, so I really don't mind if this PR is closed. I mainly wanted to bring attention to the issue. Hopefully I can contribute in a more meaningful way though some time in the future.

joeflack4 avatar May 16 '22 21:05 joeflack4

Hi @joeflack4 - thanks! You could also checkout the linkml-initializer, which is the start of a web-based project creation strategy. Closing for now, but please do try it out and give @pkalita-lbl any feedback about how it could be improved.

sierra-moxon avatar Oct 28 '22 17:10 sierra-moxon

Oh yeah, I saw that on the LinkML call last week I think. Looked pretty awesome.

joeflack4 avatar Oct 28 '22 21:10 joeflack4