linkml
linkml copied to clipboard
refactor: move converter from utils
Move linkml.utils.converter to linkml.converter.cli, which is more consistent with the structuring of other tools in the repo:
- Package for the top-level functionality.
- CLI specific to that functionality inside of that package.
- Integration into higher-level CLI.
Refactoring proposed in issue #2371.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.80%. Comparing base (c4b39f7) to head (54c5208).
:warning: Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2716 +/- ##
==========================================
+ Coverage 80.43% 83.80% +3.37%
==========================================
Files 141 141
Lines 15715 15715
Branches 3187 3187
==========================================
+ Hits 12640 13170 +530
+ Misses 2408 1842 -566
- Partials 667 703 +36
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Looking at the other files that have been put in utils, should there be a set of data utility packages? I'm not totally convinced by this one.
I do think that there are other module moves on your list that are no brainers -- e.g. moving the generators.py base model into the generators dir -- that could be done quickly and painlessly if you were willing to create PRs for them.
Thanks for your continued efforts to improve the quality and accessibility of linkml!
Looking at the other files that have been put in
utils, should there be a set of data utility packages?
@ialarmedalien the mess that the utils directories have become was the reason why @sneakers-the-rat created #2371, that motivated this PR. So a lot of changes are needed there...
Having said that, I'm not sure what you mean with "data utility packages" 🫣 Could you elaborate a bit?