linkml-runtime icon indicating copy to clipboard operation
linkml-runtime copied to clipboard

Extend checks and add pre-commit to CI

Open vladistan opened this issue 4 months ago • 4 comments

vladistan avatar Jul 18 '25 17:07 vladistan

I'll merge #406 and we can improve with this one (like https in link to editoconfig site) and add its tighter checks.

dalito avatar Jul 18 '25 18:07 dalito

So this one has two parts. First is fixing up config files like .editorconfig and main workflow, making them more similar to their counterparts in linkml repo. Second part is tailoring quality checks to the runtime, and also making checks be similar to linkml, like performing full pre-commit run on all files instead of just running ruff and codespell on python files.

I am thinking about splitting it into two smaller PRs. Although this PR is not particularly large. What do you think?

vladistan avatar Jul 18 '25 20:07 vladistan

Ok, I split this into two PRs. Turning this one into draft until we fix all problems highlighted by the lint

vladistan avatar Jul 18 '25 20:07 vladistan

@vladistan I have moved the work on this PR into the repo branch https://github.com/linkml/linkml-runtime/tree/add-checks-and-pre-commit . If you would like to continue this work please re-open the PR on the mono-repo after the merge from that branch. We'll lift it over for you so it should take less effort.

amc-corey-cox avatar Oct 20 '25 18:10 amc-corey-cox