linkml-runtime icon indicating copy to clipboard operation
linkml-runtime copied to clipboard

Fix object instantiation in `_normalize_inlined()`

Open christian-monch opened this issue 6 months ago • 2 comments

This commit fixes a problem that was discovered when using linkml-convert to convert JSON to TTL using the schema: https://concepts.inm7.de/s/simpleinput/unreleased.yaml

The original code used a dictionary as the argument to the constructor of a Pydantic class, but should have used the **-operator to convert the dictionary into keyword arguments.

christian-monch avatar May 16 '25 11:05 christian-monch

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (b2206a4) to head (9fdcd41). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
linkml_runtime/utils/yamlutils.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files          63       63           
  Lines        8938     8938           
  Branches     2584     2584           
=======================================
  Hits         5702     5702           
  Misses       2629     2629           
  Partials      607      607           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 19 '25 16:05 codecov[bot]

@christian-monch I have moved the work on this PR into the repo branch https://github.com/linkml/linkml-runtime/tree/fix-normalize-inlined . If you would like to continue this work please re-open the PR on the mono-repo after the merge from that branch. We'll lift it over for you so it should take less effort.

amc-corey-cox avatar Oct 20 '25 18:10 amc-corey-cox