medium-editor-insert-plugin icon indicating copy to clipboard operation
medium-editor-insert-plugin copied to clipboard

Insert plugin does not adhere to Medium Editor button class conventions

Open lauranjansen opened this issue 9 years ago • 4 comments

I'm currently using Medium Editor in combination with the Insert Plugin, but I have noticed that the Insert Plugin does not apply the same classes to their toolbar buttons, which makes styling them beyond the defaults unintuitive.

Medium Editor toolbar DOM classes:

<div class="medium-editor-toolbar [...] medium-toolbar-arrow-under">
    <ul class="medium-editor-toolbar-actions">
        <li>
            <button class="medium-editor-action medium-editor-button-first">
                [button1 content]
            </button>
        </li>
        <li>
            <button class="medium-editor-action">
                [button2 content]
            </button>
        </li>
        <li>
            <button class="medium-editor-action medium-editor-button-last">
                [button3 content]
            </button>
        </li>
    </ul>
</div>

However, the Insert Plugin will only add the "medium-editor-action" class to the buttons, not the "medium-editor-button-first" or "medium-editor-button-last".

lauranjansen avatar Sep 04 '15 15:09 lauranjansen

Apparently, Medium Editor added those classes only recently. I will mark this as an enhancement, so we'll remember to add them too.

linkesch avatar Sep 04 '15 16:09 linkesch

Great, thanks!

lauranjansen avatar Sep 04 '15 17:09 lauranjansen

any updates or methods to implement the buttons to the medium editor buttons? or perhaps the other way around

StuckInLoop avatar Jan 28 '16 08:01 StuckInLoop

@StuckInLoop Your question is totally unrelated to this issue, but here is an answer: https://github.com/orthes/medium-editor-insert-plugin/wiki/v2.x-Custom-addons

linkesch avatar Jan 28 '16 09:01 linkesch