website icon indicating copy to clipboard operation
website copied to clipboard

Fix typo in the "Distributed tracing with Linkerd" page

Open GTRekter opened this issue 10 months ago • 2 comments

It's treating the config as a string rather than as an object.

GTRekter avatar Mar 19 '25 15:03 GTRekter

@GTRekter i believe you'll need to amend your commit and add a DCO (developer certificate of origin) described here.

you can run something like:

git amend --signoff --no-edit && git push --force-with-lease

from your branch to push a new, amended commit.

cratelyn avatar Mar 24 '25 15:03 cratelyn

I think this needs to be fixed in 2-edge also.

travisbeckham avatar Mar 28 '25 21:03 travisbeckham

Now that the 2.18 docs are merged, we'll need to fix this in the 2.18 section as well.

travisbeckham avatar Apr 23 '25 13:04 travisbeckham

i've opened https://github.com/linkerd/website/pull/1961 to carry this over the finish line.

cratelyn avatar Apr 23 '25 17:04 cratelyn