linkerd2 icon indicating copy to clipboard operation
linkerd2 copied to clipboard

Improve `linkerd viz check` to have skip prom clusterrole checks when prom controller is disabled

Open deusxanima opened this issue 6 months ago • 3 comments

What problem are you trying to solve?

When installing linkerd-viz via Helm and setting the prometheus.enabled: false flag, we should disable the linkerd viz check for the associated resources (cluster roles, bindings...etc) since there is no longer an expectation that they will be installed in the cluster. At the moment, linkerd viz check still shows a warning like so when prometheus.enabled: false is set:

inkerd viz check
linkerd-viz
-----------
...
‼ prometheus is installed and configured correctly
missing ClusterRoles: linkerd-linkerd-viz-prometheus
see https://linkerd.io/2/checks/#l5d-viz-prometheus for hints
...
‼ data plane proxy metrics are present in Prometheus
Data plane metrics not found for linkerd/linkerd-destination-xxx, default/scheduler-xxx linkerd/linkerd-identity-xxx, ingress-nginx/ingress-nginx-controller-xxx, linkerd/linkerd-identity-xxx, default/giftcard-xxx, linkerd/linkerd-destination-xxx, default/reporting-xxx, linkerd/linkerd-identity-xxx, linkerd/linkerd-proxy-injector-xxx, default/authz-xxx, linkerd/linkerd-destination-xxx, linkerd/linkerd-proxy-injector-xxx linkerd/linkerd-proxy-injector-xxx...

How should the problem be solved?

update linkerd-viz check

Any alternatives you've considered?

n/a

How would users interact with this feature?

linkerd viz check

Would you like to work on this feature?

None

deusxanima avatar Jul 25 '24 21:07 deusxanima