linkerd2 icon indicating copy to clipboard operation
linkerd2 copied to clipboard

crds(feat): add gateway `grpcroute` crd

Open the-wondersmith opened this issue 9 months ago • 0 comments

Subject

Kubernetes Gateway API CRDs

Problem

In order to support driving traffic via Gateway GRPCRoute resources, the requisite CRD needs to be added to the linkerd-crds.

Solution

  • [X] Mirror the same feature gating used for HTTPRoute
  • [X] Add the GRPCRoute CRD to the linkerd-crds templates
  • [ ] ~~Use helm's lookup function to ensure that installation of linkerd-crds does not fail due to pre-existing installation of Gateway API CRDs or cause pre-existing Gateway API CRDs to be "absorbed" into a linkerd-crds installation~~

Validation

  • [X] helm install works as expected
  • [X] helm upgrade works as expected
  • [X] ensure bin/linkerd install --crds --set enableGrpcRoutes=true outputs the grpcroute CRD manifest
  • [X] ensure bin/linkerd install --crds --set endableGrpcRoutes=true | kubectl apply -f - correctly installs the grpcroute CRD onto the cluster
  • [X] run go test ./... --update to automatically update any test fixtures that need to be updated
  • [X] ensure go test ./... passes

Screenshots

Screenshot 2024-04-24 at 10 01 46 AM Screenshot 2024-04-24 at 10 01 40 AM

~~Fixes~~ Partially Addresses

  • #12404

the-wondersmith avatar Apr 25 '24 21:04 the-wondersmith