fix(outbound): fix clientpolicy not work after remove service profile
This is a PR for fixing https://github.com/linkerd/linkerd2/issues/14274. In linkerd/idle-cache/src/lib.rs get_or_insert_with function, seems the sidercar with service profile and sidercar with client policy has the same key, which cause the cache didn't expire after we delete serviceprofile and create the new httproute for the target sevice for pods that keep requesting the target service. this pr will create different keys for service profile httpsidecar and client policy httpsidecar to fix this problem.
@wgjak47 thanks for submitting this. i should have some bandwidth to review next week.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 67.63%. Comparing base (96124bc) to head (a7d9156).
:warning: Report is 1213 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4064 +/- ##
==========================================
- Coverage 67.68% 67.63% -0.05%
==========================================
Files 332 396 +64
Lines 15158 18660 +3502
==========================================
+ Hits 10259 12620 +2361
- Misses 4899 6040 +1141
| Files with missing lines | Coverage Δ | |
|---|---|---|
| linkerd/app/outbound/src/sidecar.rs | 61.33% <100.00%> (-7.19%) |
:arrow_down: |
... and 236 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update bb612d3...a7d9156. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@olix0r Hi,Is there any improvement needed for this pr,or there is a better way to solve this problem?