linkerd2-proxy icon indicating copy to clipboard operation
linkerd2-proxy copied to clipboard
verified publisher icon linkerd

Modify response to have `via` and `server` headers

Open aryan9600 opened this issue 4 years ago • 2 comments

This PR addresses https://github.com/linkerd/linkerd2/issues/2295. I am not very confident about this PR, hence the draft PR. Also, a rather peculiar thing, checking the response via the viz dashboard doesn't show the via or server header, but the debug statements do confirm that the response has been modified. It'd be great if I could get some feedback on how to improve this.

aryan9600 avatar Jun 06 '21 15:06 aryan9600

@aryan9600 What do you think about omitting the via header for now? Users may not necessarily want to expose this information on requests so I'd like to be a bit careful about introducing that.

I think adding a server header to Linkerd-terminated requests seems like a good compromise, though; as this information is necessary to effectively debug 5xx responses.

olix0r avatar Jun 07 '21 16:06 olix0r

Users may not necessarily want to expose this information on requests so I'd like to be a bit careful about introducing that.

What if we keep it disabled by default and add an opt-in annotation to enable this? @olix0r @hawkw

aryan9600 avatar Jun 08 '21 05:06 aryan9600